Ticket #916 (reopened defect)

Opened 4 years ago

Last modified 2 years ago

Gecko browser detection is broken

Reported by: JeremyRuston Owned by: JeremyRuston
Priority: minor Milestone: 2.6
Component: core Version:
Severity: low Keywords:
Cc:

Description

TW tests for Gecko-based browsers with the expression config.userAgent.indexOf("gecko") != -1, which does a case insensitive test for the word "Gecko" in the browser user agent string.

The config.browser.isGecko flag is used to determine whether the forceReflow() hack is used (see #320 for details).

The problem is that the browser detection code isn't sufficient; current versions of Safari include the string "gecko" in their user agent strings, and so end up running the forceReflow() hack.

Change History

Changed 4 years ago by FND

  • milestone set to 2.5.1

Changed 4 years ago by FND

  • milestone changed from 2.5.1 to 2.5.2

Might be resolved via jQuery.

Changed 4 years ago by FND

  • milestone changed from 2.5.3 to 2.5.4

Changed 4 years ago by FND

  • owner changed from JeremyRuston to FND
  • status changed from new to assigned

Changed 3 years ago by FND

  • priority changed from undefined to minor
  • severity changed from undefined to low

MDC  suggests testing for navigator.product == "Gecko" - however, apparently Safari is being deceptive there too.

There are  more  elaborate solutions, which might provide the answer.

Changed 3 years ago by FND

  • owner changed from FND to JeremyRuston
  • status changed from assigned to new

Fixed in changeset:11370.

Reassigning for review.

Changed 3 years ago by FND

  • status changed from new to closed
  • resolution set to fixed

Assuming the above fix works as expected.

Changed 2 years ago by jdlrobson

  • status changed from closed to reopened
  • resolution fixed deleted

My Safari browser is reportedly gecko thus reopening

Note: See TracTickets for help on using tickets.