Ticket #847 (closed defect: fixed)

Opened 16 months ago

Last modified 15 months ago

macros: handler is executed before init

Reported by: FND Owned by: FND
Priority: minor Milestone: 2.4.2
Component: core Version:
Severity: medium Keywords: macros
Cc:

Description


Attachments

ticket847_testcase.html Download (284.3 KB) - added by FND 16 months ago.
test case illustrating the execution order (using displayMessage)
ticket847.patch Download (1.3 KB) - added by FND 16 months ago.
moving macro initialization above store notification

Change History

Changed 16 months ago by FND

test case illustrating the execution order (using displayMessage)

Changed 16 months ago by SaqImtiaz

As seen at  http://trac.tiddlywiki.org/browser/Trunk/core/js/main.js?#L52 the macro init methods are called AFTER the restart method. This means that macros are initialized AFTER the default tiddlers are displayed, which is incorrect behavior.

init methods need to be called before restart to ensure that macros are initialized before the default tiddlers are displayed. However, it may also be necessary to call them before the store.notify call in main() to ensure that macros embedded in the PageTemplate? or MainMenu? are properly initialized.

Changed 16 months ago by SaqImtiaz

Note that should be the store.notifyAll call in main().

Changed 16 months ago by FND

moving macro initialization above store notification

Changed 16 months ago by FND

  • owner changed from JeremyRuston to FND
  • status changed from new to assigned
  • milestone changed from 2.6 to 2.4.2

Changed 15 months ago by FND

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in changeset:8161

Note: See TracTickets for help on using tickets.