Ticket #792 (closed defect: fixed)

Opened 4 years ago

Last modified 15 months ago

[TiddlyWeb] saving implementation is inconsistent with TiddlyWiki core

Reported by: mahemoff Owned by: FND
Priority: major Milestone:
Component: tiddlyweb Version:
Severity: medium Keywords: client saving
Cc:

Description (last modified by FND) (diff)

In these adaptors:

  • calling saveChanges() leads to the default (not overridden) warning dialog (because the wiki is served from  http://, it incorrectly assumes the changes won't be persisted)
  • calling store.saveTiddler() will persist the tiddler (by uploading via PUT), whereas in core, it would only change the memory model and saveChanges() would then need to be called

For now, my workaround is to rely on saveTiddler() and to clear window.saveChanges(). I believe the long term solution would be for these adaptors not to override saveTiddler, and instead override saveChanges().

Change History

Changed 4 years ago by FND

  • keywords client saving added
  • priority changed from undefined to major
  • severity changed from undefined to medium

related: #765

Changed 4 years ago by FND

  • owner changed from ChrisDent to FND
  • summary changed from TiddlyWeb and CCTiddly adaptors' saving implementations inconsistent with core to [TiddlyWeb] adaptor's saving implementations is inconsistent with TiddlyWiki core

Changed 4 years ago by FND

  • summary changed from [TiddlyWeb] adaptor's saving implementations is inconsistent with TiddlyWiki core to [TiddlyWeb] saving implementation is inconsistent with TiddlyWiki core

After discussing this with Saq, Chris and Mike, it turns out that the issue is more complicated than originally thought because not saving immediately (e.g. when offline/unplugged) means local changes might need to be tracked.

Changed 4 years ago by FND

  • description modified (diff)
  • milestone set to TiddlyWeb 1.0 beta

Changed 3 years ago by FND

  • status changed from new to closed
  • resolution set to fixed

Fixed (cf. #755)

Changed 15 months ago by cdent

  • milestone TiddlyWeb 1.0 beta deleted

Milestone TiddlyWeb 1.0 beta deleted

Note: See TracTickets for help on using tickets.