Ticket #733 (closed enhancement: wontfix)

Opened 5 years ago

Last modified 2 years ago

encapsulation for shadow tiddlers

Reported by: FND Owned by: MartinBudden
Priority: undefined Milestone: 2011.cleanup
Component: core Version:
Severity: high Keywords: encapsulation
Cc:

Description


Change History

Changed 5 years ago by FND

  • keywords encapsulation added
  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 2.5

Fixed in changeset:6365

Changed 5 years ago by MartinBudden

  • milestone changed from 2.5 to 2.4.2

Changed 5 years ago by SaqImtiaz

  • status changed from closed to reopened
  • resolution fixed deleted
  • severity changed from undefined to high

I have some concerns about the way this has been implemented, in particular that getShadowTiddlerText returns a 'empty' string - that is "" - when the shadow tiddler does not exist. This means that if I call getShadowTiddlerText and get a "" value, I cannot distinguish between a blank shadow tiddler and a non-existent one. Would be more beneficial to return undefined.

Note that whilst it is possible to call isShadowTiddler to see if the tiddler exists, this is unnecessarily complex given that getShadowTiddlerText can just return undefined.

Also note that we have a precedence with the behaviour of TiddlyWiki.prototype.getTiddlerText and getRecursiveTiddlerText. Both accept a second "defaultText" parameter to return when the tiddler does not exist and when called without this parameter return undefined.

Changed 5 years ago by MartinBudden

  • owner changed from JeremyRuston to MartinBudden
  • status changed from reopened to new

Changed 5 years ago by MartinBudden

  • milestone changed from 2.4.2 to 2.5.1

Changed 4 years ago by FND

  • milestone changed from 2.5.1 to 2.5.2

Changed 4 years ago by FND

  • milestone changed from 2.5.3 to 2.5.4

Changed 4 years ago by FND

  • milestone changed from 2.6 to 3.0

Changed 2 years ago by MartinBudden

  • status changed from new to closed
  • resolution set to wontfix
  • milestone changed from 3.0 to 2011.cleanup

The current behaviour simplifies some processing. In the cases where the user requires to know if the shadow tiddler exists there is a function that can be called.

Note: See TracTickets for help on using tickets.