Ticket #686 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

story.refreshAllTiddlers doesn't check if a Tiddler is being edited

Reported by: psd Owned by: MartinBudden
Priority: minor Milestone: 2.4.1
Component: core Version: 2.3.00
Severity: medium Keywords:
Cc:

Description

in RippleRap?, the function story.refreshAllTiddlers is periodically called from MartinBudden?'s ImportWorkspaceAdaptor? via a timer.

Unfortunately, even though "force" is false, this still results in a tiddler which is being edited, being replaced with the content from the story.

Our work-round is to override the core function to not refresh tiddlers with the string "edit" in the template name.

Seems the core should do something similar.

Attachments

ticket686.patch Download (0.9 KB) - added by MartinBudden 4 years ago.

Change History

Changed 4 years ago by psd

Even with a work-round to skip tiddlers being edited, there is also a loss of focus if the adaptor is called by a background activity, such as a timer, and a user is editing a tiddler.

Changed 4 years ago by MartinBudden

  • owner changed from JeremyRuston to MartinBudden
  • status changed from new to assigned
  • milestone set to 2.4.1

Changed 4 years ago by MartinBudden

Changed 4 years ago by MartinBudden

  • priority changed from undefined to minor
  • severity changed from undefined to medium

Changed 4 years ago by MartinBudden

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in changeset:5924

Changed 4 years ago by MartinBudden

Better fix in changeset:6224

Note: See TracTickets for help on using tickets.