Ticket #673 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

createTiddlyLink bug caused by createExternalLink

Reported by: jayfresh Owned by: jayfresh
Priority: minor Milestone: 2.4.1
Component: core Version:
Severity: low Keywords: createTiddlyLink core
Cc:

Description

External links do not have supplied className parameter attached to them.

See discussion:  http://groups.google.com/group/TiddlyWikiDev/browse_thread/thread/3e8c2de8d7b0fbfa

Patch attached.

Attachments

ticket673.patch Download (0.6 KB) - added by jayfresh 2 years ago.
patch for ticket 673

Change History

Changed 2 years ago by jayfresh

patch for ticket 673

Changed 2 years ago by jayfresh

  • owner changed from JeremyRuston to jayfresh
  • status changed from new to assigned

Changed 2 years ago by EricShulman

instead of: 

if(isStatic) btn.className+=' '+className;

I recommend using 

if(isStatic) addClass(btn,className);

This ensures that the className will only be added if not already present on the button element.

Changed 2 years ago by MartinBudden

  • milestone set to 2.4.1

Changed 2 years ago by MartinBudden

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in changeset:5903

Note: See TracTickets for help on using tickets.