Ticket #611 (closed defect: fixed)

Opened 23 months ago

Last modified 8 months ago

cancelCommand: missing confirmation prompt for new and shadow tiddlers

Reported by: FND Owned by: FND
Priority: minor Milestone: 2.5.3
Component: core Version:
Severity: medium Keywords:
Cc:

Description (last modified by FND) (diff)

When canceling during editing, a confirmation prompt currently only appears when the respective tiddler already exists in the store. When editing a new tiddler or a shadow tiddler, there is no confirmation prompt - which is inconsistent and potentially harmful.

The attached patch thus makes the confirmation prompt when one of the following conditions is met:

  • is existing tiddler and has changes
  • is new tiddler (tiddler not in store)
  • is shadow tiddler

Drawback: Closing new tiddlers or shadow tiddlers will result in a confirmation prompt even if nothing has been altered there.

Attachments

ticket611.patch Download (463 bytes) - added by FND 23 months ago.

Change History

Changed 23 months ago by FND

Changed 23 months ago by FND

  • owner changed from JeremyRuston to FND
  • status changed from new to assigned

Changed 23 months ago by FND

  • description modified (diff)

Changed 23 months ago by FND

  • description modified (diff)

Changed 12 months ago by FND

  • milestone changed from 2.5.1 to 2.5.2

Changed 8 months ago by FND

This should be solved by checking for shadow tiddlers in Story.prototype.hasChanges, making sure that the tiddler text is different from the default shadow value.

Changed 8 months ago by FND

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in changeset:10122.

Note: See TracTickets for help on using tickets.