Display jumps back to start of input field after entering a letter

[jayfresh]

If you use the option macro to display a text input box, and type into it past the end of the input box, the display jumps back to the start of the string.

This problem has been found to occur on Firefox 2 and Firefox 3 beta. This does not occur on Safari 2, nor on IE6.

Attached patch addresses the problem by setting a property on the element being typed into and when iterating through other input fields on the page only changes their value if they do not have this property set. This is a patch to config.macros.option.propagateOption.

[jayfresh]

Patch for ticket 549

[jayfresh]

Update: there is also a mod to config.macros.option.genericOnChange to pass the current element through to propagateOption.

[EricShulman]

Replying to jayfresh:

Attached patch addresses the problem by setting a property on the element being typed into and when iterating through other input fields on the page only changes their value if they do not have this property set.

Passing the current element into propagateOption() makes sense, but I don't see anywhere that you *reset* the 'active' property on that element after processing the input. The result will be that, when the same option value is subsequently entered using a different input field, *any* field that was used previously to modify the value will still have an 'active' flag set on it, and will not be sync'ed as intended.

In any case, it's doesn't seem necessary to set the 'active' property at all. Instead, when looping through the nodes, simply compare the current node with the passed in element itself, like this:

if (opt==optNode && nodes[t]!=elem)

This achieves the same result (skipping over the current input element) while not setting an extra property that is 'left behind' afterwards.

[jayfresh]

Absolutely right. Patch updated.

[jayfresh]

Second patch for 549

[MartinBudden]

Fixed in changeset:5628