Ticket #538 (closed enhancement: wontfix)

Opened 5 years ago

Last modified 5 years ago

setTiddlerTag() should update modified timestamp

Reported by: simon Owned by: FND
Priority: minor Milestone:
Component: core Version:
Severity: low Keywords:
Cc:

Description (last modified by FND) (diff)

As discussed  here, TiddlyWiki.prototype.setTiddlerTag() should (optionally) update the respective tiddler's modified timestamp.

Attachments

ticket538.patch Download (0.6 KB) - added by FND 5 years ago.
revised patch reversing logic; isModified rather than minorUpdate

Change History

Changed 5 years ago by FND

  • status changed from new to assigned
  • description modified (diff)
  • summary changed from Make TiddlyWiki.prototype.setTiddlerTag update tiddler modified time to setTiddlerTag() should update modified timestamp
  • owner changed from JeremyRuston to FND
  • type changed from defect to enhancement
  • severity changed from medium to low

Changed 5 years ago by FND

  • description modified (diff)

Changed 5 years ago by FND

revised patch reversing logic; isModified rather than minorUpdate

Changed 5 years ago by FND

  • description modified (diff)

Changed 5 years ago by JeremyRuston

  • status changed from assigned to closed
  • resolution set to wontfix

Although I can see the original motivation for this change, I don't think it's the best approach. For me, the issues are:

- changes the behaviour of an existing core function in an incompatible way (the requirement for the new parameter indicates that this is not generally a backwards compatible change) - currently, the convention that the 'modified' field is updated when you edit a tiddler is confined to the 'Story' object (moving knowledge of this convention to the TiddlyWiki object increases the chances that the 'modified' field will get inadvertantly overwritten)

Note: See TracTickets for help on using tickets.