Ticket #482 (closed enhancement: wontfix)

Opened 4 years ago

Last modified 11 months ago

A new shadow tiddler DefaultTheme is required for the new single tiddler theming mechanism

Reported by: MartinBudden Owned by: MartinBudden
Priority: major Milestone: 2.7.1
Component: core Version:
Severity: medium Keywords: themes
Cc:

Description

The DefaultTheme? shadow tiddler is required both to allow the user to set the default theme, and also as a choice within a theme selector, to allow the user to reset to the default.

Attachments

ticket482.patch Download (0.6 KB) - added by MartinBudden 4 years ago.

Change History

Changed 4 years ago by MartinBudden

  • owner JeremyRuston deleted

Changed 4 years ago by FND

See  this discussion ("DefaultOptions?") for concerns regarding this change.

Changed 4 years ago by FND

cross-reference: This issue is closely related to #361.

Changed 4 years ago by MartinBudden

Changed 4 years ago by MartinBudden

  • owner set to MartinBudden
  • status changed from new to assigned

Changed 4 years ago by JeremyRuston

I'm concerned that the DefaultTheme? tiddler invites users to try to edit it to change the default theme, especially given the parallels with DefaultTiddlers?. (What they should be doing is creating a new tiddler called MyTheme? to contain the theme, and tag it systemTheme).

The proposed alternative would be for the theme chooser to automatically create the entry for the default theme, without there actually being a systemTheme tiddler corresponding to it.

Changed 4 years ago by MartinBudden

  • status changed from assigned to new

Changed 4 years ago by MartinBudden

  • milestone changed from 2.3.1 to 2.5

Changed 4 years ago by MartinBudden

  • status changed from new to closed
  • resolution set to wontfix
  • milestone changed from 2.5 to never

Not required

Changed 3 years ago by FND

  • status changed from closed to reopened
  • severity changed from high to medium
  • resolution wontfix deleted
  • milestone changed from never to 2.6
  • keywords themes added
  • type changed from defect to enhancement

The current situation proves to be unsatisfying from an end-user's perspective - thus this issue should be reconsidered.

Changed 3 years ago by JeremyRuston

Perhaps the answer is for the new DefaultTheme? tiddler to have the default text: 

! StyleSheet
<<tiddler StyleSheet>>
! StyleSheetLayout
<<tiddler StyleSheetLayout>>
! ColorPalette
<<tiddler ColorPalette>>
// etc...

Non-default themes would generally spell out each component in full, rather than using the <<tiddler>> macro.

And then options.txtTheme would be used to switch between the DefaultTheme? and other themes.

Users could edit StyleSheet? directly if they wanted, or they could hack the theme directly.

I don't think this scheme is workable right now (the refresh mechanism would struggle to trigger a notification for DefaultTheme? when the underlying StyleSheet? was modified, for instance), but it seems like it might be a more consistent way for the themes to operate with the old-school restyling stuff.

Changed 18 months ago by MartinBudden

  • milestone changed from 2.6.2 to 2.7.1

Milestone 2.6.2 deleted

Changed 16 months ago by MartinBudden

  • status changed from reopened to new

Changed 16 months ago by MartinBudden

  • status changed from new to closed
  • resolution set to wontfix

Won't fix. The DefaultTheme? shadow tiddler is not required, and as Jeremy points out, can result in a confusing or an unworkable solution.

Changed 11 months ago by amog2011

And then options.txtTheme would be used to switch between the DefaultTheme?? and other themes.

air jordan
Note: See TracTickets for help on using tickets.