Ticket #477 (closed defect: fixed)

Opened 8 months ago

Last modified 8 months ago

'close' command should warn before closing if tiddler is dirty

Reported by: SaqImtiaz Owned by: FND
Priority: major Milestone: 2.3.1
Component: core Version:
Severity: medium Keywords:
Cc:

Description (last modified by FND) (diff)

The tiddler toolbar's Close command should warn the user if the tiddler is dirty, similar to the Cancel command.

This protects against losing data by accidentally closing a tiddler, e.g. if the user has added the Close command to the EditTemplate? or if there are input fields in the ViewTemplate?. (Plugins and macros creating input fields in ViewTemplate? can set the dirty attribute of the tiddler when the input values are changed.)

The code cost is negligible and this is perfectly backwards compatible.

Attachments

ticket477.patch (463 bytes) - added by FND 8 months ago.
adapted from config.commands.cancelTiddler - N.B.: uses config.commands.cancelTiddler.warning

Change History

Changed 8 months ago by FND

adapted from config.commands.cancelTiddler - N.B.: uses config.commands.cancelTiddler.warning

Changed 8 months ago by FND

  • description modified (diff)
  • severity changed from undefined to medium

Changed 8 months ago by MartinBudden

  • owner JeremyRuston deleted

Changed 8 months ago by FND

  • owner set to FND
  • status changed from new to assigned

Changed 8 months ago by JeremyRuston

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in changeset:3555

Note: See TracTickets for help on using tickets.