TiddlyWiki.org

WikiTimelineRoadmapBrowse SourceView TicketsSearchSimile Timeline

Ticket #476 (closed defect: fixed)

Opened 5 months ago

Last modified 4 months ago

'file' adaptor should be renamed to 'tiddlywiki'

Reported by: SaqImtiaz Assigned to: SaqImtiaz
Priority: major Milestone: 2.3.1
Component: core Version:
Severity: medium Keywords:
Cc:

Description

The name 'file' adaptor is misleading to users when using the import mechanism. In keeping with adaptor names for other wikis, the file adaptor should be renamed to tiddlywiki.

Attachments

Ticket476.patch (0.9 kB) - added by SaqImtiaz on 17/02/08 11:21:43.
patch updated to provide optional label for server types

Change History

16/02/08 02:17:09 changed by SaqImtiaz

  • owner changed from JeremyRuston to SaqImtiaz.
  • status changed from new to assigned.

16/02/08 16:58:04 changed by JeremyRuston

  • status changed from assigned to closed.
  • resolution set to wontfix.

There are backwards compatibility issues with this change. After a tiddler has been imported with the file adaptor it will (by default) be given the extended attribute server.type="file". This is done so that subsequent sync operations know which adaptor to use for the tiddler.

A horrible hacky solution would be to add an additional entry to config.adaptorsfile? for backwards compatibility.

Better might be to treat this as a localisation problem, and add the ability to have a description string (eg "TiddlyWiki file") associated with each adaptor, and to use that description in the dropdown that appears in ImportTiddlers?.

17/02/08 11:21:43 changed by SaqImtiaz

  • attachment Ticket476.patch added.

patch updated to provide optional label for server types

17/02/08 11:24:18 changed by SaqImtiaz

  • priority changed from minor to major.
  • status changed from closed to reopened.
  • resolution deleted.

I've updated the patch to introduce an optional label string for each adaptor, used for descriptive purposes by the serverType select dropdown in the importTiddlers interface. This should now be perfectly backwards compatible.

It is a small change but should improve the user experience significantly.

18/02/08 14:50:11 changed by MartinBudden

  • milestone changed from 2.3.1 to 2.4.

(follow-up: ↓ 6 ) 18/02/08 15:06:28 changed by MartinBudden

I agree that this needs to be fixed. However anychanges will have fairly widespread ramifications, since it effects all adaptors. I've moved this ticket to the 2.4 release to allow us time to consider all the issues.

(in reply to: ↑ 5 ) 26/02/08 17:11:19 changed by FND

  • severity changed from undefined to medium.
  • milestone changed from 2.4 to 2.3.1.

Replying to MartinBudden:

I agree that this needs to be fixed. However anychanges will have fairly widespread ramifications, since it effects all adaptors. I've moved this ticket to the 2.4 release to allow us time to consider all the issues.

I respectfully disagree; as I understand Saq's patch, if the serverLabel property is not defined for the respective adaptor, it'll simply use the existing serverType property as fallback value. Thus there shouldn't be any ramifications here.

Given that this is a simple fix and a huge improvement in terms of usability, I think it should definitely make its way into v2.3.1.

17/03/08 15:51:16 changed by JeremyRuston

  • status changed from reopened to closed.
  • resolution set to fixed.

Fixed in changeset:4019

Meta

Visit the Trac open source project at
http://trac.edgewall.org/