Ticket #472 (new defect)

Opened 8 months ago

Last modified 6 months ago

invalid tiddler IDs (due to spaces)

Reported by: FND Owned by:
Priority: trivial Milestone: 2.5
Component: core Version:
Severity: trivial Keywords: webStandards
Cc:

Description (last modified by FND) (diff)

As discussed here, tiddler IDs generated from the respective tiddler's title can contain spaces, resulting in invalid IDs. Thus spaces should be removed or replaced in IDs.

Rationale

Apart from conforming to web standards, this would also make it easier to use CSS ID selectors.

Potential Problems

Plugins assuming that the ID for a story tiddler is story.idPrefix + tiddler.title would become non-functional in some cases. However, fixing this should be very simple.

Change History

Changed 8 months ago by FND

  • owner changed from JeremyRuston to FND
  • status changed from new to assigned

Changed 8 months ago by MartinBudden

  • milestone set to 2.3.1

MartinB - sent comments to Fred about how to improve patches and deleted current patches

Changed 8 months ago by FND

  • owner FND deleted
  • status changed from assigned to new
  • description modified (diff)

Changed 8 months ago by FND

  • description modified (diff)

Changed 8 months ago by FND

cross reference: This issue is closely related to #475.

Changed 8 months ago by MartinBudden

  • milestone changed from 2.3.1 to 2.4

Changed 8 months ago by EricShulman

"Plugins assuming that the ID for a story tiddler is story.idPrefix + tiddler.title would become non-functional in some cases. However, fixing this should be very simple."

This assumption likely occurs in ALL plugins that are currently assembling tiddler DOM element IDs from tiddler titles, and would have a VERY LARGE IMPACT on the installed base, and should NOT be done without extensive review and a lengthy 'beta' shakedown.

If at all possible, a backward-compatible switch should be provided to ease the upgrade path (allowing older plugins to continue working until users choose to update them).

While the rationale given for this change makes sense (i.e., web standards, and CSS use of ID selectors), given the potential problems that can arise, I don't think it is a compelling justification for making this change.

Changed 6 months ago by MartinBudden

  • milestone changed from 2.4 to 2.5
Note: See TracTickets for help on using tickets.