Ticket #459 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

mozillaLoadFile does not close input streams

Reported by: XavierVerges Owned by: SaqImtiaz
Priority: minor Milestone: 2.3.1
Component: core Version:
Severity: medium Keywords:
Cc:

Description

It probably does not have any adverse effects, but mozillaLoadFile() should close the streams that it has openeded before returning the contents. It is a matter of changing  http://trac.tiddlywiki.org/browser/Trunk/core/js/FileSystem.js#L235

return sInputStream.read(sInputStream.available());

for

var contents = sInputStream.read(sInputStream.available());
sInputStream.close();
inputStream.close();
return contents;

Attachments

ticket459.patch Download (0.7 KB) - added by FND 4 years ago.
patch as per XavierVerges?' instructions

Change History

Changed 4 years ago by FND

patch as per XavierVerges?' instructions

Changed 4 years ago by FND

  • owner changed from JeremyRuston to XavierVerges

Changed 4 years ago by MartinBudden

  • priority changed from undefined to minor
  • severity changed from undefined to medium
  • milestone set to 2.3.1

Changed 4 years ago by SaqImtiaz

  • owner changed from XavierVerges to SaqImtiaz
  • status changed from new to assigned

Changed 4 years ago by JeremyRuston

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in changeset:3532

Note: See TracTickets for help on using tickets.