TiddlyWiki.org

Ticket #459 (closed defect: fixed)

Opened 7 months ago

Last modified 6 months ago

mozillaLoadFile does not close input streams

Reported by: XavierVerges Assigned to: SaqImtiaz
Priority: minor Milestone: 2.3.1
Component: core Version:
Severity: medium Keywords:
Cc:

Description

It probably does not have any adverse effects, but mozillaLoadFile() should close the streams that it has openeded before returning the contents. It is a matter of changing http://trac.tiddlywiki.org/browser/Trunk/core/js/FileSystem.js#L235

return sInputStream.read(sInputStream.available());

for

var contents = sInputStream.read(sInputStream.available());
sInputStream.close();
inputStream.close();
return contents;

Attachments

ticket459.patch (0.7 kB) - added by FND on 03/02/08 08:21:52.
patch as per XavierVerges?' instructions

Change History

03/02/08 08:21:52 changed by FND

  • attachment ticket459.patch added.

patch as per XavierVerges?' instructions

03/02/08 08:22:30 changed by FND

  • owner changed from JeremyRuston to XavierVerges.

06/02/08 15:13:52 changed by MartinBudden

  • priority changed from undefined to minor.
  • severity changed from undefined to medium.
  • milestone set to 2.3.1.

16/02/08 02:18:05 changed by SaqImtiaz

  • owner changed from XavierVerges to SaqImtiaz.
  • status changed from new to assigned.

16/02/08 16:51:33 changed by JeremyRuston

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed in changeset:3532