Ticket Navigation

Ticket #436 (closed defect: fixed)

Opened 7 months ago

Last modified 5 months ago

permalinks with commas

Reported by:	FND	Assigned to:	MartinBudden
Priority:	major	Milestone:	2.3.1
Component:	core	Version:
Severity:	medium	Keywords:
Cc:

Description

As reported here by Andrew, there is a bug relating to tiddlers with commas in their name:

A tiddler with a name like "Test,Name" will get a permalink Test%2CName - when that link is opened, TiddlyWiki does not resolve %2C into a comma, but instead looks for a tiddler with the name "Test%2CName".

This is because config.commands.permalink.handler() uses encodeURIComponent(), while getParameters() uses just decodeURI() (without the Component).

The fix is to ensure consistency in the use of encodeURI/decodeURI.

Attachments

ticket436.patch (466 bytes) - added by MartinBudden on 19/02/08 10:25:01.

Change History

25/01/08 21:22:12 changed by FND

priority changed from minor to major.

29/01/08 14:03:25 changed by MartinBudden

owner deleted.
milestone set to 2.3.1.

19/02/08 10:25:01 changed by MartinBudden

attachment ticket436.patch added.

19/02/08 10:25:15 changed by MartinBudden

owner set to MartinBudden.
status changed from new to assigned.

19/02/08 14:53:49 changed by JeremyRuston

status changed from assigned to closed.
resolution set to wontfix.

Have a look at the documentation here that goes into some details about the differences between decodeURI and decodeURIComponent:

http://livedocs.adobe.com/labs/flex3/langref/package.html#decodeURIComponent()

By my reading, we should be using decodeURIComponent(), and not decodeURI()

19/02/08 14:54:40 changed by JeremyRuston

status changed from closed to reopened.
resolution deleted.

Oops, apologies Martin, I failed to read the patch properly - it's already correct.

19/02/08 14:56:33 changed by JeremyRuston

status changed from reopened to closed.
resolution set to fixed.

Fixed in changeset:3559

Search

TiddlyWiki.org