Ticket #436 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

permalinks with commas

Reported by: FND Owned by: MartinBudden
Priority: major Milestone: 2.3.1
Component: core Version:
Severity: medium Keywords:
Cc:

Description

As reported  here by Andrew, there is a bug relating to tiddlers with commas in their name:

A tiddler with a name like "Test,Name" will get a permalink Test%2CName - when that link is opened, TiddlyWiki does not resolve %2C into a comma, but instead looks for a tiddler with the name "Test%2CName".

This is because config.commands.permalink.handler() uses encodeURIComponent(), while getParameters() uses just decodeURI() (without the Component).

The fix is to ensure consistency in the use of encodeURI/decodeURI.

Attachments

ticket436.patch Download (466 bytes) - added by MartinBudden 5 years ago.

Change History

Changed 5 years ago by FND

  • priority changed from minor to major

Changed 5 years ago by MartinBudden

  • owner JeremyRuston deleted
  • milestone set to 2.3.1

Changed 5 years ago by MartinBudden

Changed 5 years ago by MartinBudden

  • owner set to MartinBudden
  • status changed from new to assigned

Changed 5 years ago by JeremyRuston

  • status changed from assigned to closed
  • resolution set to wontfix

Have a look at the documentation here that goes into some details about the differences between decodeURI and decodeURIComponent:

 http://livedocs.adobe.com/labs/flex3/langref/package.html#decodeURIComponent()

By my reading, we should be using decodeURIComponent(), and not decodeURI()

Changed 5 years ago by JeremyRuston

  • status changed from closed to reopened
  • resolution wontfix deleted

Oops, apologies Martin, I failed to read the patch properly - it's already correct.

Changed 5 years ago by JeremyRuston

  • status changed from reopened to closed
  • resolution set to fixed

Fixed in changeset:3559

Note: See TracTickets for help on using tickets.