TiddlyWiki.org

WikiTimelineRoadmapBrowse SourceView TicketsSearchSimile Timeline

Ticket #381 (closed defect: fixed)

Opened 11 months ago

Last modified 10 months ago

FileAdaptor should honour tags specifier in TiddlerFilter slice of feed tiddlers

Reported by: MartinBudden Assigned to: MartinBudden
Priority: minor Milestone: 2.2.6
Component: core Version: 2.1.03
Severity: medium Keywords:
Cc:

Description

That way the user could specify (say):

|~TiddlerFilter:|[tags[systemConfig]]

in a feed.

Attachments

ticket381.patch (4.6 kB) - added by MartinBudden on 28/09/07 14:53:58.
jonl.patch (1.3 kB) - added by jayfresh on 01/10/07 17:53:49.
ticket381_jonl_tiddler.patch (2.1 kB) - added by jayfresh on 01/10/07 17:56:11.

Change History

24/09/07 13:34:47 changed by PhilHawksworth

  • owner set to PhilHawksworth.

24/09/07 13:35:12 changed by PhilHawksworth

  • status changed from new to assigned.

28/09/07 14:53:58 changed by MartinBudden

  • attachment ticket381.patch added.

28/09/07 14:54:45 changed by MartinBudden

  • owner changed from PhilHawksworth to MartinBudden.
  • status changed from assigned to new.

28/09/07 14:55:08 changed by MartinBudden

  • status changed from new to assigned.

01/10/07 17:53:49 changed by jayfresh

  • attachment jonl.patch added.

01/10/07 17:56:11 changed by jayfresh

  • attachment ticket381_jonl_tiddler.patch added.

01/10/07 17:58:58 changed by jayfresh

I noticed that in TiddlyWiki.prototype.filterTiddlers, when we match filter expressions of the form [tag[one two]], the function treats "one two" as a single tag and uses tiddler.isTagged on it.

I have submitted two patches that between them define a new function isTaggedAllOf and change filterTiddlers so that these expressions are treated correctly. I included a function isTaggedAnyOf, in case we decide that [tag[one two]] means "or" rather than "and".

J.

08/10/07 15:25:50 changed by MartinBudden

Jon,

[tag[one two]] is designed to treat "one two" as a single tag - this is the syntax agreed with Jeremy. This means your patches should not be applied.

Martin

08/10/07 18:36:54 changed by jayfresh

Thanks Martin, would like to withdraw my patches.

09/10/07 11:30:44 changed by JeremyRuston

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed in changeset:2574

Meta

Visit the Trac open source project at
http://trac.edgewall.org/