Ticket #381 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

FileAdaptor should honour tags specifier in TiddlerFilter slice of feed tiddlers

Reported by: MartinBudden Owned by: MartinBudden
Priority: minor Milestone: 2.2.6
Component: core Version: 2.1.03
Severity: medium Keywords:
Cc:

Description

That way the user could specify (say):

|~TiddlerFilter:|[tags[systemConfig]]

in a feed.

Attachments

ticket381.patch Download (4.6 KB) - added by MartinBudden 6 years ago.
jonl.patch Download (1.3 KB) - added by jayfresh 6 years ago.
ticket381_jonl_tiddler.patch Download (2.1 KB) - added by jayfresh 6 years ago.

Change History

Changed 6 years ago by PhilHawksworth

  • owner set to PhilHawksworth

Changed 6 years ago by PhilHawksworth

  • status changed from new to assigned

Changed 6 years ago by MartinBudden

Changed 6 years ago by MartinBudden

  • owner changed from PhilHawksworth to MartinBudden
  • status changed from assigned to new

Changed 6 years ago by MartinBudden

  • status changed from new to assigned

Changed 6 years ago by jayfresh

Changed 6 years ago by jayfresh

Changed 6 years ago by jayfresh

I noticed that in TiddlyWiki.prototype.filterTiddlers, when we match filter expressions of the form [tag[one two]], the function treats "one two" as a single tag and uses tiddler.isTagged on it.

I have submitted two patches that between them define a new function isTaggedAllOf and change filterTiddlers so that these expressions are treated correctly. I included a function isTaggedAnyOf, in case we decide that [tag[one two]] means "or" rather than "and".

J.

Changed 6 years ago by MartinBudden

Jon,

[tag[one two]] is designed to treat "one two" as a single tag - this is the syntax agreed with Jeremy. This means your patches should not be applied.

Martin

Changed 6 years ago by jayfresh

Thanks Martin, would like to withdraw my patches.

Changed 6 years ago by JeremyRuston

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in changeset:2574

Note: See TracTickets for help on using tickets.