Ticket #370 (closed defect: duplicate)

Opened 4 years ago

Last modified 3 years ago

flawed slices RegEx

Reported by: lyallp Owned by:
Priority: major Milestone: 2.4.2
Component: core Version: 2.2.04
Severity: medium Keywords: slices
Cc:

Description

Please find the following two tiddlywikis (nice clean versions from tiddlywiki.com - version 2.2.4 )

 http://remotely-helpful.com/TiddlyWiki/TestSlicesDefault.html

This demonstrates various slice formats (around 700 or 800 combinations) and what the current 2.2.4 slice regexp does with the values.

 http://remotely-helpful.com/TiddlyWiki/TestSlices.html

This demonstrates a revised slice regexp (which currently does not support retrieval of more than one column of data) via a plugin. The *only* thing changed is the regexp. All the tests are identical. Not one failure. I would expect this regexp to be placed in the core.

I may have taken liberties with the expected slice naming convention, like allowing spaces in slice names.

Feel free to peruse the TheSlices? tiddler to see the various test cases.

The plugin in  http://remotely-helpful.com/TiddlyWiki/TestSlices.html contains the regexp I would expect to be placed in core.

Change History

Changed 4 years ago by lyallp

I have created a plugin ImprovedSlicesPlugin?, located in contributors/LyallPearce/ImprovedSlicesPlugin or at  http://Remotely-Helpful.com/TiddlyWiki/ImprovedSlicesPlugin.html

The code in the plugin can be directly placed into the core.

(this superscedes the example regexp I supplied in the initial ticket text)

Changed 4 years ago by FND

Also see  this discussion on tiddler slices' issues with table row headings and spaces in labels.

Changed 4 years ago by FND

  • keywords slices added; slice slicesRE removed
  • summary changed from Slices regexp in core 2.2.4 could do with improvement to flawed slices RegEx
  • milestone changed from unscheduled to 2.4

It has been  reported that slice names containing [brackets] are not recognized.

Changed 4 years ago by FND

cross-reference: #522

Changed 4 years ago by MartinBudden

  • milestone changed from 2.4 to 2.5

Changed 4 years ago by FND

  • priority changed from minor to major

Unit testing also revealed the following flaws:

  • table-heading markup (e.g. |!foo|bar|) results in the respective slice being ignored
  • potential confusion between colon and table notation: "|''//~FooBar//'':|baz|" returns slice value |baz|

Priority increased due to failing unit tests.

Changed 4 years ago by FND

various enhancements in changeset:5138

Changed 4 years ago by FND

cross-reference: #672

Changed 3 years ago by FND

  • status changed from new to closed
  • resolution set to duplicate

Fixed in #672 - optional extension in  FatSlicePlugin

Changed 3 years ago by MartinBudden

  • milestone changed from 2.5 to 2.4.2
Note: See TracTickets for help on using tickets.