TiddlyWiki.org

Ticket #310 (closed defect: fixed)

Opened 1 year ago

Last modified 5 months ago

Undefined tiddler reference in Wikifier during refresh

Reported by: UdoBorkowski Assigned to: MartinBudden
Priority: minor Milestone: 2.3.1
Component: core Version:
Severity: medium Keywords:
Cc:

Description

When wikify is called by the "content" refresher (in "Refresh.js") it does not pass in the tiddler being wikified:

	content: function(e,changeList)
		{
		var title = e.getAttribute("tiddler");
		var force = e.getAttribute("force");
		if(force != null || changeList == null || changeList.indexOf(title) != -1)
			{
			removeChildren(e);
			wikify(store.getTiddlerText(title,title),e);
			return true;
			}
		else
			return false;
		},

This leads to problems when macros/formatters called during the wikification are refering to the tiddler (link].

The wikify statement may be changed to this:

wikify(store.getTiddlerText(title,title),e,null,store.fetchTiddler(title));

Attachments

ticket310.patch (491 bytes) - added by MartinBudden on 17/03/07 14:11:44.

Change History

17/03/07 14:05:56 changed by MartinBudden

  • owner changed from JeremyRuston to MartinBudden.
  • milestone changed from 2.3 to 2.2.

17/03/07 14:11:44 changed by MartinBudden

  • attachment ticket310.patch added.

17/03/07 14:11:57 changed by MartinBudden

  • status changed from new to assigned.

17/03/07 17:45:53 changed by JeremyRuston

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed in changeset:1857

18/03/07 20:00:13 changed by MartinBudden

  • priority changed from critical to major.
  • status changed from closed to reopened.
  • resolution deleted.
  • milestone changed from 2.2 to 2.3.

Re-opened ticket since Udo's proposed change unfortunately causes some serious problems with the formatters.

18/03/07 22:05:41 changed by JeremyRuston

Retracted fix in changeset:1881

07/11/07 19:32:00 changed by MartinBudden

  • priority changed from major to minor.
  • severity changed from high to medium.

29/11/07 16:29:13 changed by MartinBudden

  • milestone set to 2.3.1.

13/02/08 18:15:35 changed by MartinBudden

  • milestone changed from 2.3.1 to 2.4.

15/02/08 12:13:11 changed by MartinBudden

  • status changed from reopened to new.
  • milestone changed from 2.4 to 2.3.1.

It turns out that this fix is safe. The problem described previously is in fact an error in the MediaWikiFormatterPlugin?.

15/02/08 12:13:19 changed by MartinBudden

  • status changed from new to assigned.

16/02/08 16:48:01 changed by JeremyRuston

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed in changeset:3531