Ticket #301 (closed defect: wontfix)

Opened 4 years ago

Last modified 3 years ago

Firefox refresh problem leading to overlapping tiddlers

Reported by: JeremyRuston Owned by:
Priority: minor Milestone: 2.3.1
Component: core Version:
Severity: medium Keywords:
Cc:

Description

As  discussed here, Firefox contains a bug that corrupts the display under certain circumstances. Steps to reproduce:

  1. Go to  http://www.tiddlywiki.com
  2. Open up options
  3. Uncheck EnableAnimations?
  4. Click "view" on GettingStarted
  5. Close Raves

Attachments

ticket301.patch Download (3.1 KB) - added by UdoBorkowski 4 years ago.
Patch to fix this ticket

Change History

Changed 4 years ago by UdoBorkowski

Fix:

in Story.prototype.closeTiddler replace


        else
            tiddlerElem.parentNode.removeChild(tiddlerElem);

by


        else 
            {
            //# see Ticket #301
            tiddlerElem.style.overflow = "hidden";
            setTimeout(function(){tiddlerElem.parentNode.removeChild(tiddlerElem)},0);
            }

Changed 4 years ago by UdoBorkowski

Patch to fix this ticket

Changed 4 years ago by UdoBorkowski

  • owner set to UdoBorkowski
  • priority changed from undefined to minor
  • status changed from new to assigned
  • severity changed from undefined to medium
  • milestone set to 2.2

Some discussion with EricShulman? improved the suggested fix to make it more compatible with older versions of TiddlyWiki.

The final solution is attached as a patch, ready to be applied on the TiddlyWiki source code.

Many thanks again to Eric for his contribution.

Changed 3 years ago by UdoBorkowski

  • owner changed from UdoBorkowski to JeremyRuston
  • status changed from assigned to new

Changed 3 years ago by f7o7

 Tiddly Tools is patched, but still has the issue. Details are in my  last post in the discussion.

Changed 3 years ago by MartinBudden

  • milestone changed from 2.2 to 2.3

Changed 3 years ago by MartinBudden

  • milestone set to 2.3.1

Changed 3 years ago by MartinBudden

  • owner JeremyRuston deleted

Changed 3 years ago by JeremyRuston

  • status changed from new to closed
  • resolution set to wontfix

Although the underlying bug is annoying, I think that this solution isn't acceptable because it fundamentally changes the semantics of one of the core APIs (making tiddler closure be an asynchronous operation), which isn't justified as a cost of fixing the underlying problem.

Note: See TracTickets for help on using tickets.