TiddlyWiki.org

Ticket #291 (closed enhancement: fixed)

Opened 2 years ago

Last modified 1 year ago

Refactor loadRemoteFile

Reported by: SaqImtiaz Assigned to:
Priority: minor Milestone: 2.2
Component: core Version:
Severity: low Keywords:
Cc:

Description

I'd like to propose that we refactor loadRemoteFile and move the following code to a separate function:

	var x;
	try
		{
		x = new XMLHttpRequest(); // Modern
		}

	catch(e)
		{
		try
			{
			x = new ActiveXObject("Msxml2.XMLHTTP"); // IE 6
			}
		catch (e)
			{
			return null;
			}
		}

Perhaps called getXMLHttpObject. That way it can be easily re-used.

Change History

22/01/07 19:59:45 changed by SaqImtiaz

  • type changed from defect to enhancement.

08/02/07 20:45:39 changed by JeremyRuston

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone changed from unscheduled to 2.2.

Fixed in changeset:1491