Ticket #284 (closed defect: wontfix)

Opened 5 years ago

Last modified 4 years ago

Not every (persistent) modification of a tiddler sets the modifier and modified fields

Reported by: UdoBorkowski Owned by:
Priority: major Milestone: 2.3
Component: core Version:
Severity: high Keywords:
Cc:

Description

Not every (persistent) modification of a tiddler sets the modifier and modified fields, resulting in inconsistent/incomplete modification histories.

Look for the calls to TiddlyWiki.prototype.setDirty(true). You will notice in some case the modifier/modified fields are set, in other cases not. I.e. if saveChanges is called in the latter cases the modification is not recognizable.

It seems to be reasonable to always update these fields when a change makes the store dirty (except in a situation like "import", maybe).

The following functions should be verified:

BTW: The setDirty(true) in TiddlyWiki.prototype.createTiddler should be removed. This function is used during the load process, i.e. the store is not really dirty after that. Actually the setDirty is cleared right after this in TiddlyWiki.prototype.loadFromDiv.

Change History

Changed 5 years ago by UdoBorkowski

  • owner set to JeremyRuston

Changed 5 years ago by JeremyRuston

  • milestone changed from 2.2 to 2.3

Changed 4 years ago by MartinBudden

  • owner JeremyRuston deleted

Changed 4 years ago by JeremyRuston

  • status changed from new to closed
  • resolution set to wontfix

The current behaviour is intentional; the UI handler code enforces the modifier and modified fields, with the underlying machinery allowing changes that don't update these fields.

With respect to the final point, TiddlyWiki.store.createTiddler() does in fact dirty the store, and so setting the flag is the correct behaviour.

Note: See TracTickets for help on using tickets.