Tiddler called "Display" causes TiddlyWiki to corrupt display

[UdoBorkowski]

Steps to reproduce

• Take an empty TW 2.1.3
• Create a tiddler "ABC"
• Press "Done"

(everything is fine)

• Create a tiddler called "Display"
• Press "Done"

Now the tiddler ABC is automatically removed from the screen and the tiddler "Display" is the only visible tiddler. The command buttons of "Display" ("close", "close other"...) are displayed without margin.

Checked on FireFox? and IE

[JeremyRuston]

It is caused because there's a clash between two assumptions:

- in the core code, that a tiddler DIVs in the main story with the title "Example" has the DOM id "tiddlerExample" - in the default stylesheets and templates, that the DIV containing the display area has the DOM id "tiddlerDisplay"

When you write it like that, it's obvious that things will not be happy when a tiddler is called "Display".

There's no easy way around this one that I can see, apart from changing the ID of the "tiddlerDisplay" element.

[JeremyRuston]

Fixed in changeset:1501 by changing the "tiddlerDisplay" id in the PageTemplate? to "storyDisplay".

I've added a rather spikey hack to stop everyone's PageTemplate? breaking whereby there's an search and replace for "tiddlerDisplay"->"storyDisplay" before applying a PageTemplate?.

[JeremyRuston]

Retracted in changeset:2220 because of backwards compatibility issues

[MartinBudden]

I think the problem can be solved by changing the creation of the story in main() from:

story = new Story("tiddlerDisplay","tiddler");

to

story = new Story("tiddlerDisplay","story");

The second parameter is the story idPrefix. This change ensures that all tiddlers in the story have an id of the form storyXXX (where XXX is the tiddler title) and so their ids cannont clash with the container div id ("tiddlerDisplay").

[MartinBudden]

Unfortunately this cannot be fixed without breaking compatibility of existing tiddlywikis. A work around that does not allow users to create tiddlers called "Display" could be implemented

[FND]

alternative implementation ensuring unique tiddler IDs

[FND]

cross-reference: #680

[MartinBudden]

Fixed in changeset:5626