Ticket #1438 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

config.macros.tiddler.transclude calls renderText with invalid argument

Reported by: cdent Owned by: JeremyRuston
Priority: undefined Milestone:
Component: core Version:
Severity: undefined Keywords:
Cc:

Description

In config.macros.tiddler.transclude we have this call:

config.macros.tiddler.renderText(wrapper,text,tiddlerName,params);

in the local scope params is undefined, which causes an error when using the code for things like twikifier.

What's worse, but makes the situation fixable: params is passed to renderText, but renderText makes no use of it:

config.macros.tiddler.renderText = function(place,text,tiddlerName,params) {

wikify(text,place,null,store.getTiddler(tiddlerName));

};

Suggested fix:

remove params from the call and signature.

Change History

Changed 2 years ago by FND

  • status changed from new to closed
  • resolution set to fixed

Nice find - one of those typical fugly remnants...

Fixed in changeset:12739.

Note: See TracTickets for help on using tickets.