Ticket #1253 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Slider macro capable of creating bad cookies

Reported by: jdlrobson Owned by: MartinBudden
Priority: minor Milestone: 2.6.2
Component: core Version:
Severity: low Keywords: cookies
Cc:

Description

If in a TiddlyWiki I include <<slider cookie GettingStarted myslider>>

This creates a blank cookie called cookie. This is fine in a normal TiddlyWiki but can cause breakages in environments such as TiddlySpace? which depend on valid parseable cookies. As a result I broke my space with the message "400 Bad Request: malformed cookie: Illegal key value: cookie" just by using this seemingly harmless macro. The only way to fix my space was then to remove the macro call and clear out my cookies.

It seems that saving cookies with the slider macro only works for cookie names that begin with 'chk' So for instance <<slider chkCookie GettingStarted myslider>> works fine.

I think the core needs to be updated to prevent the storing of blank cookies.

Change History

Changed 3 years ago by FND

  • keywords tiddlywiki tiddlywiki removed
  • summary changed from [core][tw]Slider macro capable of creating bad cookies to Slider macro capable of creating bad cookies
  • milestone set to 2.7

cf. #1143

Changed 3 years ago by MartinBudden

  • owner changed from JeremyRuston to MartinBudden

Changed 3 years ago by FND

Fixed in changeset:12424? Please confirm.

Changed 3 years ago by MartinBudden

  • priority changed from undefined to minor
  • severity changed from medium to low

Changed 3 years ago by MartinBudden

  • status changed from new to assigned

Changed 3 years ago by MartinBudden

  • status changed from assigned to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.