Ticket #1234 (new defect)

Opened 3 years ago

Last modified 3 years ago

inconsistent class names on more/less commands

Reported by: FND Owned by: MartinBudden
Priority: major Milestone: 2.7.1
Component: core Version:
Severity: low Keywords:
Cc:

Description

changeset:10120 (#849) introduced a convention for classes on toolbar commands (command name prefixed with "command_").

However, the more and less (pseudo-)commands do not adhere to this convention, using moreCommand and lessCommand instead.

This complicates parsing, as it requires special handling when constructing selectors for toolbar buttons.

Change History

Changed 3 years ago by FND

  • owner changed from JeremyRuston to MartinBudden
  • priority changed from undefined to major
  • severity changed from undefined to low

Note that the moreCommand class is also used on the container for additional commands.

Rather than just adding an additional, consistent class name, we might consider replacing the existing classes - it seems unlikely that backwards compatibility would be affected.

Changed 3 years ago by MartinBudden

  • milestone changed from 2.6.1 to 2.6.2

It's not just "moreCommand" and "lessCommand", it's also "defaultCommand" and "cancelCommand".

A less intrusive change would be to change the convention to suffix the command with "Command" rather than prefix it with "command_"

Changed 3 years ago by MartinBudden

  • milestone changed from 2.6.2 to 2.7.1

Milestone 2.6.2 deleted

Note: See TracTickets for help on using tickets.