Ticket #1165 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

[TiddlyWeb] challenger: tiddlyweb_redirect not passing on all CGI params

Reported by: mahemoff Owned by: mahemoff
Priority: undefined Milestone:
Component: tiddlyweb Version:
Severity: undefined Keywords:
Cc:

Description

 http://localhost/challenge/cookie_form?tiddlyweb_redirect=/foo?bar&baz

will redirect to

/foo?bar

instead of

/foo?bar&baz as you'd expect

I've only tested this with cookie challenger

Change History

Changed 2 years ago by cdent

  • owner changed from cdent to mahemoff
  • summary changed from challenger: tiddlyweb_redirect not passing on all CGI params to [TiddlyWeb] challenger: tiddlyweb_redirect not passing on all CGI params

you've got to escape what's passed to tiddlyweb_redirect, otherwise it's parameters are handled as parameters

in the url you've provided tiddlyweb.query will end up with tiddlyweb_redirect getting a value of /foo?bar and an entry for baz with no value

so you probably need to make tiddlyweb_redirect at least: /foo?bar%26baz

I'm assuming that you are calling the challenger and setting redirect by hand? If not, then there's a bug in the core code: it does some escaping when generating tiddlyweb_redirect.

Changed 2 years ago by cdent

  • status changed from new to closed
  • resolution set to fixed

lack of response means assent

Note: See TracTickets for help on using tickets.