Ticket #1112 (closed defect: fixed)

Opened 3 years ago

Last modified 11 months ago

[TiddlyWebWiki] TiddlyWebAdaptor sends no If-Match header for new tiddlers

Reported by: FND Owned by: cdent
Priority: critical Milestone:
Component: TiddlyWebWiki Version:
Severity: medium Keywords:
Cc:

Description (last modified by FND) (diff)

This missing ETag check means that if two users create a specific tiddler at the same time (or during the same "session"), one version will be designated as an old revision.

The correct way would be to report a 412 edit conflict.

Change History

Changed 3 years ago by FND

  • description modified (diff)

Changed 3 years ago by FND

  • priority changed from major to critical

It  appears that the adaptor only generates ETags if workspace.type == "bag".

Changed 2 years ago by FND

  • owner changed from FND to cdent
  • milestone set to TiddlyWebWiki 1.0

fixed in changeset:10302

Turns out not sending an ETag for new tiddlers is the correct behavior - cf.  http://github.com/tiddlyweb/tiddlyweb/commit/dbb0cece4c81b96cca58a09a88d6f666a0278994.

Leaving ticket open for review.

Changed 2 years ago by FND

  • status changed from new to closed
  • resolution set to fixed

additional fix in changeset:10318 (setting bag after a PUT)

Closing ticket as the behavior seems to be correct now.

Changed 11 months ago by cdent

  • milestone TiddlyWebWiki 1.0 deleted

Milestone TiddlyWebWiki? 1.0 deleted

Note: See TracTickets for help on using tickets.