Ticket #1103 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

reversed logic in httpReq's allowCache argument

Reported by: FND Owned by: FND
Priority: critical Milestone: 2.5.3
Component: core Version: 2.5.02
Severity: critical Keywords:
Cc:

Description

httpReq appends a random parameter to the URL when the allowCache is true and omits that parameter otherwise - exactly the opposite of how it's intended.

Test case:

var allowCache = true;

var callback = function(foo, bar, baz) {
	console.log(arguments);
}
var req = httpReq("GET", "http://google.com", callback, null,
	null, null, null, null, null, allowCache);

Note that this might be the reason for recent importing issues.

Attachments

ticket1103.patch Download (455 bytes) - added by FND 3 years ago.

Change History

Changed 3 years ago by FND

Changed 3 years ago by FND

  • owner changed from JeremyRuston to FND
  • status changed from new to assigned

Fixed in changeset:9980.

Leaving ticket open for review.

Changed 3 years ago by FND

  • status changed from assigned to closed
  • resolution set to fixed

Fixed additional bug in changeset:10101, which should resolve this issue.

Note: See TracTickets for help on using tickets.