evaluated macro parameters are computed twice

[FND]

As explained  here, some macros' use of parseParams causes evaluated macro parameters to be computed twice:

invokeMacro calls the respective macro's handler while passing params.readMacroParams():
 http://trac.tiddlywiki.org/browser/Trunk/core/js/main.js?rev=9473#L233
This in turn calls parseParams, which then computes evaluated parameters:
 http://trac.tiddlywiki.org/browser/Trunk/core/js/Strings.js?rev=9473#L187

However, some macros - like tiddler - also call parseParams, which leads to evaluated parameters being computed twice in those cases.

Thus fixing this issue might be as simple as relying on parseParams's allowEval argument, setting it to false in macro handlers. (That, of course, would require plugin authors to be aware of this somewhat obscure issue.)

Test case:

<<tiddler {{alert(new Date()); ""}}>>

[FND]

It appears this is not fixable without changing behavior and thus breaking backwards compatibility.

[FND]

Changing this in the invokeMacro framework would break backwards compatibility.

Similarly, changing each individual macro's parseParams call to suppress evaluation would make the code counterintuitive (suggesting evaluated parameters are unsupported) and may also have unexpected side effects.

Thus wontfix due to backwards compatibility concerns.

[MartinBudden]

Eric has a suitable fix:

 http://groups.google.co.uk/group/tiddlywikidev/browse_thread/thread/2b066938c5ce3772

[MartinBudden]

Fixed in changeset:11296