Ticket #1033 (closed enhancement: wontfix)

Opened 4 years ago

Last modified 2 years ago

Refactor RefreshTidder internals

Reported by: PhilHawksworth Owned by: JeremyRuston
Priority: minor Milestone: 2011.cleanup
Component: core Version:
Severity: trivial Keywords: jQuery, refactor
Cc:

Description

Refactor the internals of RefreshTiddler? to reduce its size and make use of jQuery.

Change History

in reply to: ↑ description   Changed 4 years ago by EricShulman

Replying to PhilHawksworth:

Refactor the internals of RefreshTiddler? to reduce its size and make use of jQuery.

Clearly, refreshTiddler() should be refactored both for size and jQuery-usage purposes.

However... please be *extremely* cautious when re-writing the code in this function, as it is central to *ALL* TiddlyWiki rendering, and can also be easily affected by browser-specific rendering issues.

For example, Internet Explorer can be particularly sensitive to the order in which elements are created and processed (e.g., some types of elements have to be inserted into the DOM before their attributes are set, or IE won't be able to properly initialize and render those elements).

Some of the kinds of problems that have popped up in the past included multiple-redraws, 'blink/flash' effects during redraws, elements that are not refreshed when they should be, elements that are refreshed when they shouldn't be, etc.

All I'm saying is: Please be careful, do LOTS of testing, and make sure this function is 'code reviewed' by as many developers as possible before any patched code is accepted.

  Changed 4 years ago by MartinBudden

  • milestone changed from 2.5.1 to 2.5.2

  Changed 4 years ago by FND

  • milestone changed from 2.5.3 to 2.6

  Changed 3 years ago by MartinBudden

  • milestone changed from 2.6.2 to 2.7.1

Milestone 2.6.2 deleted

  Changed 2 years ago by cdent

  • status changed from new to closed
  • resolution set to wontfix
  • milestone changed from 2.7.1 to 2011.cleanup

no use case, no patch, just a wish, a dream but not with the current reality (unfortunately)

Note: See TracTickets for help on using tickets.