TiddlyWiki.org

Changeset 2814

Show
Ignore:
Timestamp:
12/11/07 16:18:49 (10 months ago)
Author:
JeremyRuston
Message:

Refactored displayTiddler() to accept a Tiddler() object as well as a tiddler title (ticket #170)

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • Trunk/core/js/Paramifiers.js

    r2120 r2814  
    6161        onstart: function(v) { 
    6262                var tagged = store.getTaggedTiddlers(v,"title"); 
    63                 for(var t=0; t<tagged.length; t++) 
    64                         story.displayTiddler("bottom",tagged[t].title,null,false,null); 
     63                story.displayTiddlers(null,tagged,null,false,null); 
    6564        } 
    6665}; 
     
    9392}; 
    9493 
     94 
  • Trunk/core/js/Story.js

    r2774 r2814  
    3232 
    3333//# Display several tiddlers given their titles in an array. Parameters same as displayTiddler(), except: 
    34 //# titles - array of string titles 
     34//# titles - array of tiddlers or string titles 
    3535Story.prototype.displayTiddlers = function(srcElement,titles,template,animate,unused,customFields,toggle) 
    3636{ 
     
    4444//# srcElement - reference to element from which this one is being opened -or- 
    4545//#              special positions "top", "bottom" 
    46 //# title - title of tiddler to display 
     46//# tiddler - tiddler or title of tiddler to display 
    4747//# template - the name of the tiddler containing the template -or- 
    4848//#            one of the constants DEFAULT_VIEW_TEMPLATE and DEFAULT_EDIT_TEMPLATE -or- 
     
    5151//# customFields - an optional list of name:"value" pairs to be assigned as tiddler fields (for edit templates) 
    5252//# toggle - if true, causes the tiddler to be closed if it is already opened 
    53 Story.prototype.displayTiddler = function(srcElement,title,template,animate,unused,customFields,toggle) 
    54 
     53Story.prototype.displayTiddler = function(srcElement,tiddler,template,animate,unused,customFields,toggle) 
     54
     55        var title = (tiddler instanceof Tiddler)? tiddler.title : tiddler;   
    5556        var place = document.getElementById(this.container); 
    5657        var tiddlerElem = document.getElementById(this.idPrefix + title); 
     
    492493        highlightHack = new RegExp(useRegExp ?   text : text.escapeRegExp(),useCaseSensitive ? "mg" : "img"); 
    493494        var matches = store.search(highlightHack,"title","excludeSearch"); 
    494         var titles = []; 
    495         for(var t=0;t<matches.length;t++) 
    496                 titles.push(matches[t].title); 
    497         this.displayTiddlers(null,titles); 
     495        this.displayTiddlers(null,matches); 
    498496        highlightHack = null; 
    499497        var q = useRegExp ? "/" : "'"; 
    500498        if(matches.length > 0) 
    501                 displayMessage(config.macros.search.successMsg.format([titles.length.toString(),q + text + q])); 
     499                displayMessage(config.macros.search.successMsg.format([matches.length.toString(),q + text + q])); 
    502500        else 
    503501                displayMessage(config.macros.search.failureMsg.format([q + text + q])); 
     
    601599}; 
    602600 
     601 
  • Trunk/core/js/Utilities.js

    r2806 r2814  
    184184        var tag = this.getAttribute("tag"); 
    185185        var tagged = store.getTaggedTiddlers(tag); 
    186         var titles = []; 
    187         for(var t=0; t<tagged.length; t++) 
    188                 titles.push(tagged[t].title); 
    189         story.displayTiddlers(this,titles); 
     186        story.displayTiddlers(this,tagged); 
    190187        return false; 
    191188} 
     
    291288} 
    292289 
     290 
  • Trunk/core/js/main.js

    r2809 r2814  
    8686        if(story.isEmpty()) { 
    8787                var tiddlers = store.filterTiddlers(store.getTiddlerText("DefaultTiddlers")); 
    88                 for(var t=0; t<tiddlers.length; t++) { 
    89                         story.displayTiddler("bottom",tiddlers[t].title); 
    90                 } 
     88                story.displayTiddlers(null,tiddlers); 
    9189        } 
    9290        window.scrollTo(0,0);